Skip to content

change: link to offical BIPs for BIP340-342 #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

0xB10C
Copy link
Contributor

@0xB10C 0xB10C commented Mar 2, 2020

fixes #347

I left the following untouched as the link to the transaction digest section is no longer up to date. I'll let you to decide how to follow up with this one.

- title: bip-tapscript (transaction digest)
link: https://github.com/sipa/bips/blob/bip-schnorr/bip-tapscript.mediawiki#Transaction_digest

@jnewbery jnewbery force-pushed the 2020-03-link-to-official-bips-340-2 branch from e6ca590 to a2e9931 Compare March 2, 2020 18:12
@jnewbery
Copy link
Contributor

jnewbery commented Mar 2, 2020

I think netlify is a spurious failure. I don't think I have access to restart builds so I just force-pushed an empty update to kick off the build again.

I left the following untouched as the link to the transaction digest section is no longer up to date. I'll let you to decide how to follow up with this one.

I think it should link to https://github.com/bitcoin/bips/blob/master/bip-0341.mediawiki#common-signature-message, which describes the transaction digest.

There are still a bunch of links to https://github.com/sipa/bips/blob/bip-schnorr in old newsletters which are now dead, but I think that's the nature of writing a newsletter. Some of the links will die over time and we shouldn't go back and change them if that happens.

0xB10C added 2 commits March 2, 2020 23:29
The old link broke as it linked to and older and not up to date
version of the BIP in sips's repo.
@0xB10C 0xB10C force-pushed the 2020-03-link-to-official-bips-340-2 branch from a2e9931 to ffe8534 Compare March 2, 2020 22:34
@0xB10C
Copy link
Contributor Author

0xB10C commented Mar 2, 2020

I think it should link to https://github.com/bitcoin/bips/blob/master/bip-0341.mediawiki#common-signature-message, which describes the transaction digest.

Pushed a commit addressing that.

There are still a bunch of links to https://github.com/sipa/bips/blob/bip-schnorr in old newsletters which are now dead, but I think that's the nature of writing a newsletter. Some of the links will die over time and we shouldn't go back and change them if that happens.

I as well think the links in the newsletters should not be changed afterwards. This would create a lot of maintenance work and, in this case, they still link to the repo which was relevant at that time. Somebody doing archaeology in 10 years might be grateful to find the links unchanged.

@harding
Copy link
Collaborator

harding commented Mar 3, 2020

Untested LGTM. Thanks @0xB10C!

I agree with generally avoiding changing broken external links in old newsletters.

@jnewbery jnewbery merged commit edeab27 into bitcoinops:master Mar 3, 2020
@jnewbery jnewbery added the website General website changes and maintenance label Mar 6, 2020
Walpurga03 added a commit to Walpurga03/bitcoinops.github.io that referenced this pull request Jun 29, 2025
Walpurga03 added a commit to Walpurga03/bitcoinops.github.io that referenced this pull request Jun 29, 2025
murchandamus added a commit that referenced this pull request Jun 30, 2025
* Translate Newsletter #360 to German

* Translate Newsletter #360 to German

* fix link

* Update _posts/de/newsletters/2025-06-27-newsletter.md

Co-authored-by: garfiel-d <[email protected]>

* Update _posts/de/newsletters/2025-06-27-newsletter.md

Co-authored-by: garfiel-d <[email protected]>

* Update _posts/de/newsletters/2025-06-27-newsletter.md

Co-authored-by: garfiel-d <[email protected]>

* Update _posts/de/newsletters/2025-06-27-newsletter.md

Co-authored-by: garfiel-d <[email protected]>

* Update _posts/de/newsletters/2025-06-27-newsletter.md

Co-authored-by: garfiel-d <[email protected]>

* Update _posts/de/newsletters/2025-06-27-newsletter.md

Co-authored-by: Mark "Murch" Erhardt <[email protected]>

---------

Co-authored-by: garfiel-d <[email protected]>
Co-authored-by: Mark "Murch" Erhardt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website General website changes and maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Schnorr, Taproot topics to point to official BIPs
3 participants