-
Notifications
You must be signed in to change notification settings - Fork 137
change: link to offical BIPs for BIP340-342 #360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change: link to offical BIPs for BIP340-342 #360
Conversation
e6ca590
to
a2e9931
Compare
I think netlify is a spurious failure. I don't think I have access to restart builds so I just force-pushed an empty update to kick off the build again.
I think it should link to https://github.com/bitcoin/bips/blob/master/bip-0341.mediawiki#common-signature-message, which describes the transaction digest. There are still a bunch of links to |
The old link broke as it linked to and older and not up to date version of the BIP in sips's repo.
a2e9931
to
ffe8534
Compare
Pushed a commit addressing that.
I as well think the links in the newsletters should not be changed afterwards. This would create a lot of maintenance work and, in this case, they still link to the repo which was relevant at that time. Somebody doing archaeology in 10 years might be grateful to find the links unchanged. |
Untested LGTM. Thanks @0xB10C! I agree with generally avoiding changing broken external links in old newsletters. |
* Translate Newsletter #360 to German * Translate Newsletter #360 to German * fix link * Update _posts/de/newsletters/2025-06-27-newsletter.md Co-authored-by: garfiel-d <[email protected]> * Update _posts/de/newsletters/2025-06-27-newsletter.md Co-authored-by: garfiel-d <[email protected]> * Update _posts/de/newsletters/2025-06-27-newsletter.md Co-authored-by: garfiel-d <[email protected]> * Update _posts/de/newsletters/2025-06-27-newsletter.md Co-authored-by: garfiel-d <[email protected]> * Update _posts/de/newsletters/2025-06-27-newsletter.md Co-authored-by: garfiel-d <[email protected]> * Update _posts/de/newsletters/2025-06-27-newsletter.md Co-authored-by: Mark "Murch" Erhardt <[email protected]> --------- Co-authored-by: garfiel-d <[email protected]> Co-authored-by: Mark "Murch" Erhardt <[email protected]>
fixes #347
I left the following untouched as the link to the transaction digest section is no longer up to date. I'll let you to decide how to follow up with this one.
bitcoinops.github.io/_topics/en/op_codeseparator.md
Lines 110 to 111 in f3f9b7a