Enable fp16/bf16 absmax #1672
Open
Enable fp16/bf16 absmax #1672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
jiqing-feng
force-pushed
the
absmax
branch
2 times, most recently
from
69b2146 to
50ee994
Compare
|
Hi @matthewdouglas . I kept cuda op the same as before, only enabled cpu/xpu absmax on half-precision. This PR could pass all cuda tests on A100 and all cpu tests on Intel Xeon node. For XPU, we have around 20 tests failed because of compile error but not introduced by this PR. So please review this PR. Thanks! |
Signed-off-by: jiqing-feng <[email protected]>
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @matthewdouglas , enable fp16/bf16 absmax on XPU could get 20% speed-up on our qlora case. Please review it. I am checking if there are any failed tests on CUDA, will let you know once it's completed. BTW, the tests are too much...