Skip to content

Update openblas-src to 0.10 #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2021

Conversation

maoe
Copy link
Contributor

@maoe maoe commented Mar 24, 2021

No description provided.

@IvanUkhov
Copy link
Member

Thank you. Would you be able to update lapack-src too?

@bluss
Copy link
Contributor

bluss commented Mar 24, 2021

Hi. Just a question (don't want to stop anything). Is there a reason openblas-src is getting bumps in the 0.x version? This causes incompatible version number upgrades in blas-src and those that depend on blas-src (causing incompatible version bumps further downstream). Is this a necessary bump - or could openblas-src for example avoid using the version number 0.11 for a long time?

Will you release blas-src with a bumped version soon (question)? If so I want to coordinate and wait with ndarray 0.15 just a day or two so that we're up to date with you. Thanks 🙂

@IvanUkhov
Copy link
Member

@termoshtt, what is your opinion on the versioning of openblas-src?

@termoshtt
Copy link
Member

termoshtt commented Mar 24, 2021

In my understanding, we keep the minor version (0.10) unless as far as features in Cargo.toml and ABI of BLAS and LAPACK are kept. 0.10.2 includes large changes around the Fortran compiler detection sneaking blas-lapack-rs/openblas-src#47 , but it only bump up patch version.

@bluss
Copy link
Contributor

bluss commented Mar 24, 2021

Thanks for the info. I guess I was also ignorant of what goes into the openblas-src releases 🙂 Nice job. Maybe it would be possible for blas-src to match with several openblas-src versions? I don't know if that can be practical.

@maoe
Copy link
Contributor Author

maoe commented Mar 24, 2021

Would you be able to update lapack-src too?

Sure, will do.

@maoe
Copy link
Contributor Author

maoe commented Mar 24, 2021

Done blas-lapack-rs/lapack-src#5

@maoe
Copy link
Contributor Author

maoe commented Mar 24, 2021

BTW, current version of blas-src is compatible with openblas-src 0.9 and 0.10. So technically speaking it should be possible to specify >= 0.9, < 0.11, which is a common practice in the Haskell community to support a wider range of dependencies. But as far as I can see it's rare to see this kind of version bounds in the Rust community. Why is that?

@bluss
Copy link
Contributor

bluss commented Mar 24, 2021

@maoe I think the reason is that cargo will always pick the newest version. One could imagine cargo trying to pick the "best" version in that range to get all crates in a project to build, but it doesn't do that, if I understand correctly.

@maoe
Copy link
Contributor Author

maoe commented Mar 24, 2021

Ah I see. Haskell's cabal tries to solve the version constraints then pick the latest versions (this is what you called the "best", I think) amongst the possible solutions.

@IvanUkhov IvanUkhov closed this Mar 25, 2021
@IvanUkhov IvanUkhov reopened this Mar 25, 2021
@IvanUkhov IvanUkhov merged commit ebb98da into blas-lapack-rs:master Mar 25, 2021
@IvanUkhov
Copy link
Member

Thank you!

@maoe maoe deleted the openblas-src-0.10 branch March 25, 2021 12:51
@maoe maoe restored the openblas-src-0.10 branch March 26, 2021 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants