MB-66395: API change to accommodate batch execution of queries #62
+10
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinavdangeti
added a commit
to blevesearch/zapx
that referenced
this pull request
May 23, 2025
abhinavdangeti
added a commit
to blevesearch/zapx
that referenced
this pull request
May 23, 2025
abhinavdangeti
added a commit
to blevesearch/bleve
that referenced
this pull request
May 23, 2025
abhinavdangeti
added a commit
to blevesearch/bleve
that referenced
this pull request
May 23, 2025
abhinavdangeti
added a commit
to blevesearch/bleve
that referenced
this pull request
May 23, 2025
| @@ -66,16 +67,21 @@ type VectorIndex interface { | |||
| Size() uint64 | |||
| } | |||
|
|
|||
| const DefaultBatchExecutionDelay = time.Duration(100 * time.Millisecond) | |||
|
|
|||
| type InterpretVectorIndexOptions struct { | |||
There was a problem hiding this comment.
i think these would be more useful in bleve_index_api as they are index-specific configurables (from the end-user perspective) and not segment-specific configurables (one value for these configs affects all segments, not just one segment).
BleveVectorSearchBatchExecutionDelay = segment_api.DefaultBatchExecutionDelay
perhaps can be genralized to
type VectorIndexOptions struct {
There was a problem hiding this comment.
Perhaps, for now - let me just leave these here (next to what they're applicable to).
abhinavdangeti
added a commit
to blevesearch/zapx
that referenced
this pull request
May 27, 2025
abhinavdangeti
added a commit
to blevesearch/bleve
that referenced
this pull request
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.