Add dark mode css variables #2802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this PR. Yeah... I did not think about the dark theme... You are right... I am not sure how we address theming in the application at the moment. I will merge your PR to fix the awful color scheme for people using a dark theme... and we can start to discuss theming support. I just started to add better colors and some shadow effects to make navigating the options a bit more easy... I am sure there is much more improvements that could be made... but this was a test to see if users would like it... or hate it ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly opening for discussion, but the recent format changes look nice with the base theme, but the dark theme is not very nice.
Current Dark Theme
PR Dark Theme
I'm not attached to the colors, but I just wanted to maybe start the conversation about how to handle common themes.