Remove num-bigint dependency and rely on primitives #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nekevss
force-pushed
the
remove-bigint
branch
from
8f9ed6a to
32049db
Compare
| // 1. Let timeZone be the this value. | ||
| // 2. Perform ? RequireInternalSlot(timeZone, [[InitializedTemporalTimeZone]]). | ||
| // 3. Set instant to ? ToTemporalInstant(instant). | ||
| // 4. If timeZone.[[OffsetMinutes]] is not empty, return 𝔽(timeZone.[[OffsetMinutes]] × (60 × 10^9)). | ||
| if let Some(offset) = &self.offset { | ||
| return Ok(BigInt::from(i64::from(*offset) * 60_000_000_000i64)); | ||
| return Ok(i128::from(*offset) * 60_000_000_000); |
There was a problem hiding this comment.
We may want to add a comment under the offset property to say its offset minutes from UTC, as it's more descriptively called offsetMinutes in the spec
jasonwilliams
approved these changes
Oct 30, 2024
jedel1043
added
C-enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
num_bigintdependency from the project that was primarily technical debt from the earlier days oftemporal_rs