Add from_partial methods to PlainTime, PlainDate, and PlainDateTime
#106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nekevss
added
C-documentation
ptomato
reviewed
Nov 15, 2024
| partial.year.is_some() || (partial.era.is_some() && partial.era_year.is_some()); | ||
| let month_check = partial.month.is_some() || partial.month_code.is_some(); | ||
| if !year_check || !month_check || partial.day.is_none() { | ||
| return Err(TemporalError::range().with_message("Invalid PlainDate fields provided.")); |
There was a problem hiding this comment.
I think this is supposed to be a TypeError. If I understand the Rust code correctly, it's implementing a part of CalendarResolveFields?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR primarily adds
from_partialmethods toPlainTime,PlainDate, andPlainDateTime.This also begins to add doc tests to some high visibility methods and also sets the Constrain option of ArithmeticOverflow as the default.