Add ZonedDateTime calendar accessor methods
#117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nekevss
force-pushed
the
impl-zdt-calendar-methods
branch
from
15b4056 to
9baaaa4
Compare
nekevss
force-pushed
the
impl-zdt-calendar-methods
branch
from
9baaaa4 to
0920d60
Compare
jedel1043
approved these changes
Dec 7, 2024
| self.hours_in_day_with_provider(provider.deref()) | ||
| } | ||
|
|
||
| pub fn hours_in_day_with_provider(&self, provider: &impl TzProvider) -> TemporalResult<u8> { |
There was a problem hiding this comment.
Thought: we should probably change the provider argument to &(impl TzProvider + ?Sized), since the current type doesn't allow passing trait objects.
There was a problem hiding this comment.
Hmmm, true. I'll update in a follow up.
jedel1043
added
C-enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is dependent on #115 and will need a rebase once that PR is merged.
This continues to build out methods that
ZonedDateTimeneeds for accessor methods.Overall the features implemented are:
HoursInDaymethod