Skip to content

Migrate repo to workspace #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 7, 2024
Merged

Migrate repo to workspace #126

merged 2 commits into from
Dec 7, 2024

Conversation

jedel1043
Copy link
Member

This migration enables adding more crates to the repo, like the soon-to-be test262-tester or the temporal_capi FFI.

@jedel1043 jedel1043 added the C-meta Changes about the repository itself label Dec 7, 2024
nekevss
nekevss approved these changes Dec 7, 2024
View reviewed changes
Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a couple nits for the workspace, but its not necessarily blocking (1 in a review, the other below here).

I think it would make more sense to label the temporal directory as temporal vs. temporal_rs.

@jedel1043
Copy link
Member Author

@nekevss Almost completely forgot that you can have a root package on a workspace 😅
Changed the structure so that we don't need to have a temporal directory, but with a workspace to add crates to.

@jedel1043 jedel1043 requested a review from nekevss December 7, 2024 19:18
@nekevss nekevss merged commit 232ae15 into main Dec 7, 2024
5 checks passed
@jedel1043 jedel1043 deleted the workspaces branch December 7, 2024 19:53
@jedel1043 jedel1043 mentioned this pull request Dec 7, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nekevss nekevss nekevss approved these changes

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

Assignees
No one assigned
Labels
C-meta Changes about the repository itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jedel1043 @nekevss