Skip to content

Fix Calendar::from_str to be case-insensitive #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Dec 16, 2024

With the recent updates to Calendar::from_str, it looks like there were some regressions, primarily around lowercase calendar identifiers. This updates the new method and adds a test to help ensure it does not regress in the future.

@nekevss nekevss merged commit 4498edf into main Dec 18, 2024
5 checks passed
@nekevss nekevss deleted the calendar-case-insensitive branch December 22, 2024 15:59
@jedel1043 jedel1043 added the C-bug Something isn't working label Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants