Skip to content

Complete some general cleanup of temporal_rs #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 23, 2024
Merged

Complete some general cleanup of temporal_rs #138

merged 4 commits into from
Dec 23, 2024

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Dec 22, 2024 •
edited
Loading

This PR is primarily to do some cleanup that's been needed.

An overview of the changes made are below.

  • Adds a calendar field to PartialDate
  • Removes the IsoDateSlots trait that was no longer needed
  • Makes the ISO records public
  • Adds IsoDate to the calendar API over PlainDate
  • Some docs cleanup

@nekevss nekevss marked this pull request as ready for review December 22, 2024 17:20
@nekevss nekevss merged commit 955f1d4 into main Dec 23, 2024
5 checks passed
@nekevss nekevss deleted the general-cleanup branch December 25, 2024 01:42
@jedel1043 jedel1043 added the C-internal Internal library improvements label Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raskad raskad raskad approved these changes

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

@jedel1043 jedel1043 Awaiting requested review from jedel1043

Assignees
No one assigned
Labels
C-internal Internal library improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nekevss @raskad @jedel1043