Add validation logic to from_diff_settings
#144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
reviewed
Dec 25, 2024
src/options.rs
Outdated
| // 11. If LargerOfTwoTemporalUnits(largestUnit, smallestUnit) is not largestUnit, throw a RangeError exception. | ||
| // 12. Let maximum be MaximumTemporalDurationRoundingIncrement(smallestUnit). | ||
| // 13. If maximum is not unset, perform ? ValidateTemporalRoundingIncrement(roundingIncrement, maximum, false). | ||
| if largest_unit.max(smallest_unit) != largest_unit { |
There was a problem hiding this comment.
Does TemporalUnit implement Ord? Because even if the spec says otherwise, I think it would be better to do a simpler if largest_unit < smallest_unit.
There was a problem hiding this comment.
Hmmmmmm, yeah that's probably true. I believe it should implement Ord
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds missing steps from
GetDifferenceSettingsto the options resolution logic offrom_diff_settings