Skip to content

Extend implementation of to_ixdtf_string to more types #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jan 12, 2025
Merged

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Jan 12, 2025

This PR continues the work on implementing toString functionality in temporal_rs.

It completes the following:

  • Adds to_ixdtf_string functions on DateTime, Time, ZonedDateTime, and Instant.
  • Adds ToStringRoundingOptions options type.
  • Adds an IxdtfStringBuilder struct to assist with building ixdtf strings.

So far I have verfied that the PR has a 100% conformance rate for PlainDateTime. I plan to test the others, but any poentially issues that may arise with those could always be completed in subsequent PRs.

Copy link
Member

@jasonwilliams jasonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nekevss nekevss merged commit bd96e91 into main Jan 12, 2025
5 checks passed
@nekevss nekevss deleted the extend-to-string branch January 12, 2025 18:59
@jedel1043 jedel1043 added C-enhancement New feature or request C-api Changes related to the public API labels Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-api Changes related to the public API C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants