Skip to content

Update time zone parsing to include other ixdtf formats #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2025
Merged

Update time zone parsing to include other ixdtf formats #193

merged 1 commit into from
Feb 17, 2025

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Feb 16, 2025

This PR implements better handling of ParseTemporalTimeZoneString.

It adds logic to parse that an IANA identifier is valid and removes the eager provider validation from the try_from_str method in favor.

@nekevss nekevss added C-api Changes related to the public API C-internal Internal library improvements labels Feb 16, 2025
@nekevss nekevss merged commit 1e4a438 into main Feb 17, 2025
7 checks passed
@nekevss nekevss deleted the update-timezone-parsing branch February 18, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonwilliams jasonwilliams jasonwilliams approved these changes

@jedel1043 jedel1043 Awaiting requested review from jedel1043

Assignees
No one assigned
Labels
C-api Changes related to the public API C-internal Internal library improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nekevss @jasonwilliams