Build out stubs for remaining unimplemented methods #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nekevss
requested review from
Razican,
hansl,
jasonwilliams,
HalidOdat,
raskad and
jedel1043
Manishearth
reviewed
Feb 21, 2025
| @@ -228,6 +228,7 @@ pub mod ffi { | |||
| } | |||
|
|
|||
| // TODO round_with_provider (needs time zone stuff) | |||
| // TODO total_with_provider (needs time zone stuff) | |||
There was a problem hiding this comment.
thanks for adding this, easier for me to do a big pass when I add tz stuff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unimplemented methods not being stubbed came up today in the ICU4X call. This implements stubs for the remaining unimplemented methods that I'm currently aware of nobody working on (in order to minimize any conflicts with ongoing work).
This PR also takes a stab at adding the
temporal_capimethods.CC: @Manishearth