Reject datetime when fraction digits are too large #229
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were unwrapping rather than rejecting on the new
to_nanosecond
method forFraction
.Context:
to_nanosecond
returns anOption<u32>
, which represents the nanoseconds value when the digits are < 9, but returnsNone
if the digits exceed 9.I think this mostly points towards a doc improvement needed in
ixdtf
that also links toto_truncated_nanosecond
to show the difference between the two cases.