Clean up API ergonomics for calendar methods #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
approved these changes
Mar 4, 2025
|
Yeah, it's nice to know and have that tested reliably for our max and min dates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a lot of the
TemporalResultreturns from most of the calendar methods.This is made possible on most methods because we no longer need to support Not Yet Implemented errors.
There is also an expect added in the conversion from
IsoDate->icu_calendar::Date<Iso>. This is tested to be valid in a test added toiso.rsfor the max bounds ofIsoDate.The core changes in this PR are made to
iso.rsandcalendar.rsby extension. The rest is mostly updating all the calendar methods accordingly.Note: calendar methods that are still not fully implemented across various calendars were left as a
TemporalResult