Since until #259
Merged
Since until #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Tennebekk/temporal into add-since-until-yearmonth
nekevss
requested changes
Apr 8, 2025
src/builtins/core/year_month.rs
Outdated
| // 15. Let duration be CombineDateAndTimeDuration(yearsMonthsDifference, 0). | ||
| let mut duration = NormalizedDurationRecord::from_date_duration(*result.date())?; | ||
| // 16. If settings.[[SmallestUnit]] is not month or settings.[[RoundingIncrement]] ≠ 1, then | ||
| if settings.smallest_unit != Some(TemporalUnit::Month) |
There was a problem hiding this comment.
issue: I believe this should be using the resolved options in resolved.
src/options.rs
Outdated
| // 1. NOTE: The following steps read options and perform independent validation in alphabetical order. | ||
| // 2. Let largestUnit be ? GetTemporalUnitValuedOption(options, "largestUnit", unitGroup, auto). | ||
| // Week and day is the only use case where any of the units are not allowed. | ||
| if dissallow_week_and_day { |
There was a problem hiding this comment.
thought: is there anything preventing moving this into PlainYearMonth::diff vs. where it's currently at in ResolvedRoundingOptions::from_diff_settings.
This only affects the one code path from PlainYearMonth, I think, so maybe this could work in PlainYearMonth::diff. This would then avoid the check occurring for the other callers.
…resolved from settings in diff and moved logic from options.rs from_diff_setting into diff
nekevss
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #142
Worked with @HenrikTennebekk and @Magnus-Fjeldstad
Implementation for since and until in PlainYearMonth, has not yet been tested with boa test262