Generate the baked zone info data for ZoneInfoProvider #264
+80,420
−139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's time to finally tackle the zoneinfo and tzif sourcing issue. The work here lays the baseline for to handle sourcing. There's still a lot more to add, and maybe some bugs to uncover. But this is also major progress.
nekevss
force-pushed
the
zoneinfo-datagen
branch
from
e6810ab to
8fa1437
Compare
|
Just to note, it may be better to merge #265 first and update the data in this PR. |
nekevss
force-pushed
the
zoneinfo-datagen
branch
3 times, most recently
from
b073658 to
c6b2f9a
Compare
Co-authored-by: Sean Burke <[email protected]>
|
I think it would be good to describe exactly how you generated this with some steps, or even update the documentation, in case someone else needs to re-do it. |
|
True, I only added the comment to the bakeddata tool README. It should be in contrib guide too. |
nekevss
pushed a commit
that referenced
this pull request
Jun 10, 2025
Compiled data should not hit the filesystem. Once #264 is done we can remove the caching code.
|
I think it's going to be best to merge #265 prior to merging the data build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the follow up for
impl-zoneinfo-supportonce merged with the actual baked data generated with the bakeddata tool.