Skip to content

Remove keywords from Cargo.toml #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 25, 2024
Merged

Remove keywords from Cargo.toml #28

merged 4 commits into from
Feb 25, 2024

Conversation

jedel1043
Copy link
Member 

error: failed to publish to registry at https://crates.io/
Caused by:
  the remote server responded with an error: expected at most 5 keywords per crate

@jedel1043 jedel1043 added the C-meta Changes about the repository itself label Feb 25, 2024
@jedel1043 jedel1043 requested a review from nekevss February 25, 2024 19:08
@jedel1043 jedel1043 changed the title Remove keyword from Cargo.toml Remove keywords from Cargo.toml Feb 25, 2024
nekevss
nekevss approved these changes Feb 25, 2024
View reviewed changes
Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, that's my bad. 😅 LGTM

@jedel1043
Copy link
Member Author

Also noticed that the categories don't exist on crates.io. Will change that just in case.

@jedel1043 jedel1043 marked this pull request as draft February 25, 2024 19:13
@nekevss
Copy link
Member

nekevss commented Feb 25, 2024

Looking at generally similar libraries, "date", "time", "calendar", "timezone", and "duration" might be best.

Lib.rs

@jedel1043
Copy link
Member Author

Yeah, we can publish using those and modify them if needed in the future.

@jedel1043 jedel1043 marked this pull request as ready for review February 25, 2024 19:23
@jedel1043 jedel1043 requested a review from nekevss February 25, 2024 19:23
@jedel1043 jedel1043 merged commit 23f784f into main Feb 25, 2024
@jedel1043 jedel1043 deleted the keywords branch February 25, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nekevss nekevss nekevss approved these changes

Assignees
No one assigned
Labels
C-meta Changes about the repository itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jedel1043 @nekevss