Fix loop in diff_iso_date
#31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The issue was actually with not using |
jedel1043
approved these changes
Mar 4, 2024
| let y = year + (month - 1) / 12; | ||
| // 1. Assert: year and month are integers. | ||
| // 2. Set year to year + floor((month - 1) / 12). | ||
| let y = year + (month - 1).div_euclid(12); |
There was a problem hiding this comment.
Oof, that's a really tricky bug.
There was a problem hiding this comment.
It took longer than I'd like to admit to notice it too 😭
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29
Fixes the issue that was being causing
diff_iso_dateto loop and notes it for the future.Adds the test case that was causing the initial issue.