Make duration capi getters non-optional #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
force-pushed
the
nonoptional-duration
branch
from
585bb8f to
5bc1e8d
Compare
|
I prefer this approach I think. It doesn't introduce behavior that's not in the specification. |
nekevss
approved these changes
May 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #313
This should only be merged if the
temporal_capi 0.0.8release has not happened yet, since these APIs are not yet used in v8 but will be very shortly.(In general, if the C++ API is changing I'd love to have a heads up and perhaps a gradual migration in cases where v8 uses the API since it makes upgrades a bit more annoying)