Skip to content

Generate FFI bindings for C #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 28, 2025
Merged

Generate FFI bindings for C #321

merged 5 commits into from
May 28, 2025

Conversation

jedel1043
Copy link
Member

Fixes #320.

@jedel1043 jedel1043 requested a review from nekevss May 28, 2025 14:34
@jedel1043 jedel1043 added C-api Changes related to the public API C-FFI Changes related to FFI labels May 28, 2025
@nekevss
Copy link
Member

nekevss commented May 28, 2025

This looks good to me and roundabout what I'd expect when I was looking

CC: @Manishearth

Just to confirm, these bindings won't conflict with the CPP bindings in V8, correct?

Manishearth
Manishearth approved these changes May 28, 2025
View reviewed changes
Copy link
Contributor

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They will not conflict

@nekevss nekevss merged commit 0537926 into main May 28, 2025
8 checks passed
@nekevss nekevss deleted the gen-c-ffi branch May 28, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth approved these changes

@nekevss nekevss nekevss approved these changes

Assignees
No one assigned
Labels
C-api Changes related to the public API C-FFI Changes related to FFI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add binding support for C
3 participants
@jedel1043 @nekevss @Manishearth