Skip to content

Fix abstract method 7.5.36 BubbleRelativeDuration() #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 28, 2025

Conversation

HalidOdat
Copy link
Member

This PR makes abstract specification method 7.5.36 BubbleRelativeDuration() conform to the latest specification.

Conformance

Comparing temporal main vs. PR, we have some fixed tests 🥳

Test262 conformance changes:
| Test result | main |    PR   | difference |
|    Passed   | 46900  | 46910 |    -10     |
|   Ignored   |  1634  | 1634  |     0      |
|   Failed    |  1720  | 1710  |     10     |
|   Panics    |   2    |   2   |     0      |

Fixed tests (10):
test/built-ins/Temporal/PlainYearMonth/prototype/until/round-cross-unit-boundary.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/since/round-cross-unit-boundary.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/until/round-cross-unit-boundary.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/since/round-cross-unit-boundary.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/round/balances-up-to-next-unit-after-rounding.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/round/round-cross-unit-boundary.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/until/round-cross-unit-boundary.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/since/round-cross-unit-boundary.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/round-cross-unit-boundary.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/since/round-cross-unit-boundary.js (previously Failed)

@HalidOdat HalidOdat requested a review from nekevss May 28, 2025 22:13
Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! This was one of the bugs I was really hoping to get fixed soon, so it's great to see.

I had one general review comment. But I'm fine with merging either way for now.

@HalidOdat HalidOdat force-pushed the fix/spec-sec-temporal-bubblerelativeduration branch from 9a580c9 to 4160465 Compare May 28, 2025 23:12
@HalidOdat HalidOdat merged commit bde6236 into main May 28, 2025
8 checks passed
@HalidOdat HalidOdat deleted the fix/spec-sec-temporal-bubblerelativeduration branch May 28, 2025 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants