Skip to content

Implement Time's until and since methods #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2024
Merged

Implement Time's until and since methods #36

merged 1 commit into from
Mar 31, 2024

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Mar 17, 2024

Implements the until and since methods for the Time component.

@nekevss nekevss added this to the 0.1 Blocking milestone Mar 17, 2024
@nekevss nekevss added the C-enhancement New feature or request label Mar 17, 2024
jedel1043
jedel1043 reviewed Mar 28, 2024
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good! just have a small suggestion.

@nekevss nekevss merged commit efb607a into main Mar 31, 2024
@nekevss nekevss deleted the time-until-since branch May 20, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedel1043 jedel1043 jedel1043 approved these changes

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

Assignees
No one assigned
Labels
C-enhancement New feature or request
Projects
None yet
Milestone
0.1 Blocking
Development

Successfully merging this pull request may close these issues.
2 participants
@nekevss @jedel1043