[capi] Fix i128Nanoseconds #372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
commented
Jun 24, 2025
| pub struct I128Nanoseconds { | ||
| pub high: i64, | ||
| pub high: u64, |
There was a problem hiding this comment.
Note: this is a breaking change for capi, but I've mitigated it in v8.
nekevss
approved these changes
Jun 24, 2025
|
Closes #352 (thanks!) |
hubot
pushed a commit
to v8/v8
that referenced
this pull request
Jun 24, 2025
temporal_capi had a bad representation of i128, and is switching to a different one. Prepare for this change. Until this point only positive nanosecond values was working correctly. Note: this will not fully work until boa-dev/temporal#372 lands, but this prepares the codebase for that update. Bug: 427190223 Change-Id: I6a6a69641a696bab0728ea0a9aa4271bcbc49207 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6663150 Reviewed-by: Jakob Kummerow <[email protected]> Commit-Queue: Manish Goregaokar <[email protected]> Cr-Commit-Position: refs/heads/main@{#101008}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were doing the math wrong for negative numbers; since there is no -0.
I've switched the representation over to two u64s. This is technically breaking for the capi, but I plan to handle the migration smoothly.
V8 CL: https://chromium-review.googlesource.com/c/v8/v8/+/6663150