Skip to content

Add struct to encapsulate invariants of rounding increments #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2024

Conversation

jedel1043
Copy link
Member

This saves a bit of memory on the parameter list (Option<NonZeroU32> is 4 bytes, while Option<f64> is 16 bytes).

@jedel1043 jedel1043 added C-enhancement New feature or request C-api Changes related to the public API labels Jun 2, 2024
Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, but definitely always down for a better repr 😄

@nekevss
Copy link
Member

nekevss commented Jun 8, 2024

Looks like this needs a rebase

@jedel1043 jedel1043 force-pushed the strict-rounding-increments branch from 5f9aa80 to fc8762b Compare June 16, 2024 22:56
@jedel1043 jedel1043 merged commit fc769df into main Jun 16, 2024
5 checks passed
@jedel1043 jedel1043 deleted the strict-rounding-increments branch June 16, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-api Changes related to the public API C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants