Skip to content

Cleanup rounding increment usages with new struct #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

jedel1043
Copy link
Member

@jedel1043 jedel1043 commented Jun 16, 2024

Cleans up all usages of the rounding increment so that all have to pass through RoundingIncrement, increasing strictness.
Also moves the RoundingIncrement struct from options.rs to its own increment.rs file

@jedel1043 jedel1043 added C-enhancement New feature or request C-internal Internal library improvements labels Jun 16, 2024
Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move RoundingIncrement to a rounding.rs file. I'm hoping that may make the rebase a little easier. I'm also then not moving it over from options.rs to rounding.rs

@jedel1043 jedel1043 requested a review from nekevss June 16, 2024 23:59
@jedel1043 jedel1043 merged commit 028c369 into main Jun 17, 2024
5 checks passed
@jedel1043 jedel1043 deleted the cleanup-rounding-inc branch June 17, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request C-internal Internal library improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants