Reject IsoDate when outside the allowed range
#62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
added
C-bug
nekevss
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
I'd be fine with merging this as is, but I think I'd prefer this go on the constructor for IsoDate after taking a look at it.
The date from IsoDate::new_unchecked needs to be validated to be within limits on the constrain and reject options. Plus, that then allows implementing the check with iso_dt_within_valid_limits
|
Yep, I'd also advocate for that, but we can do that on some future cleanups when we're certain that the spec won't suddenly change |
|
Im not convinced that part of the spec will change. At least on the date and datetime constructor. Those are pretty stable. |
|
Hmm, in that case I'll just move this to the constructor. |
jedel1043
force-pushed
the
deny-iso-date-range
branch
from
07771a3 to
f10919f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe we could move the check to
IsoDate's constructor? For now this is enough to pass test262.