Skip to content

Update duration validation and switch asserts to debug-asserts #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 7, 2024
Merged

Update duration validation and switch asserts to debug-asserts #73

merged 3 commits into from
Jul 7, 2024

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Jul 6, 2024

This updates the is_valid_duration check to the current specification and also changes a couple asserts into debug_asserts to prevent panics.

@nekevss nekevss mentioned this pull request Jul 6, 2024
Merged
jedel1043
jedel1043 reviewed Jul 6, 2024
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a new temporal_assert, similar to temporal_unwrap that throws an error on release?

@nekevss
Copy link
Member Author

nekevss commented Jul 6, 2024

Yeah, that's not a bad approach. If we added an assert with a log, it might make debugging easier too. I'll add it to this quick.

jedel1043
jedel1043 approved these changes Jul 6, 2024
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jedel1043 jedel1043 merged commit cf70b50 into main Jul 7, 2024
5 checks passed
@jedel1043 jedel1043 deleted the update-invalid-duration branch July 7, 2024 00:20
@jedel1043 jedel1043 added the C-internal Internal library improvements label Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raskad raskad raskad approved these changes

@jedel1043 jedel1043 jedel1043 approved these changes

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

Assignees
No one assigned
Labels
C-internal Internal library improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nekevss @raskad @jedel1043