Implement DateTime diffing methods Until and Since
#83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nekevss
added
C-enhancement
jedel1043
requested changes
Jul 17, 2024
src/components/datetime.rs
Outdated
|
|
||
| // Step 12 | ||
| match sign { | ||
| crate::Sign::Positive => Ok(result), |
There was a problem hiding this comment.
You can avoid the panic by also matching against Sign::Zero here.
src/components/datetime.rs
Outdated
| DifferenceSettings { | ||
| largest_unit: None, | ||
| smallest_unit: Some(smallest), | ||
| increment: Some(unsafe { RoundingIncrement::new_unchecked(increment) }), |
There was a problem hiding this comment.
I would prefer if we didn't use unsafe here. We can just use try_new and unwrap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements diffing for
DateTimeand the correspondingsinceanduntilmethods.TODO: add basic unit tests for the methods.