Add with_* methods to Date and DateTime
#84
Conversation
nekevss
added
C-enhancement
src/components/date.rs
Outdated
| calendar: dt.calendar().clone(), | ||
| } | ||
| /// Creates a | ||
| pub fn with_calendar<I>(&self, calendar_like: Option<I>) -> TemporalResult<Self> |
There was a problem hiding this comment.
I don't think we should accept an Option<I: Into<Calendar>> for something that only requires a calendar. We should just require users to pass the calendar directly, and delegate calling into to them.
There was a problem hiding this comment.
That's fair. The intent in this instance was to try and mimic the proposal as much as possible around accepting a calendarLike vs. a calendar. But there's not really any negative to restricting to just a calendar. It's probably a better API too.
Mostly speaking of #55 as far as the API, but maybe that should be rethought?
There was a problem hiding this comment.
I think the spec API is fine, but in my opinion the APIs should be adapted to the explicitness of Rust APIs instead of having a 1-1 equivalent in both, which in this case means having some function that people can call to get the calendar before calling the function, instead of filling the API with generics.
There was a problem hiding this comment.
This is partly because any APIs that have generics in them will make it really difficult to implement FFI interfaces for them.
Per title, this PR adds
with_calendarandwith_timemethods toDateandDateTime. This also adds someFromimpls forCalendar.