Implement DateTime round method
#88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
approved these changes
Jul 21, 2024
src/iso.rs
Outdated
| _ => { | ||
| return Err(TemporalError::range() | ||
| .with_message("Invalid temporal unit provided to Time.round.")) | ||
| .with_message("Invalid smallestUNit value for time rounding.")) |
There was a problem hiding this comment.
Suggested change
| .with_message("Invalid smallestUNit value for time rounding.")) | |
| .with_message("Invalid smallestUnit value for time rounding.")) |
nekevss
force-pushed
the
impl-dt-rounding
branch
from
6837488 to
3d7face
Compare
jedel1043
reviewed
Jul 21, 2024
src/iso.rs
Outdated
Comment on lines
685
to
692
| ((((i128::from(self.hour) * 60 + i128::from(self.minute)) * 60 | ||
| + i128::from(self.second)) | ||
| * 1000 | ||
| + i128::from(self.millisecond)) | ||
| * 1000 | ||
| + i128::from(self.microsecond)) | ||
| * 1000 | ||
| + i128::from(self.nanosecond) |
There was a problem hiding this comment.
Nit: I think this could benefit from separating it on several variables, even if they're just used once. Also applies to the other branches that do a big operation like this.
There was a problem hiding this comment.
Yeah, it would probably help with the readability.
nekevss
added
C-enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
DateTime:round. In order to do this,IsoDateTime::roundneeded to be implemented, andIsoTime::roundwas updated to the current specification version