Skip to content

Add is empty for partialDuration #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 10, 2024
Merged

Add is empty for partialDuration #90

merged 2 commits into from
Aug 10, 2024

Conversation

jasonwilliams
Copy link
Member

@jasonwilliams jasonwilliams commented Jul 31, 2024 •
edited
Loading

Changes here are needed for boa-dev/boa#3856

  • We need a way of checking if a partialDuration is empty, I don't know if the changes here would work, open to ideas.
  • We need to be able to convert from Finite64 back to f64 so I've added a From impl (for more info see the errors here:

@nekevss
Copy link
Member

nekevss commented Jul 31, 2024

I think this is implemented as is_zero and as_inner.

@jasonwilliams jasonwilliams changed the title is empty and impl From<FiniteF64> Add is empty for partialDuration Aug 10, 2024
@nekevss nekevss merged commit af94bbc into main Aug 10, 2024
5 checks passed
@jedel1043 jedel1043 deleted the monthDayYearMonth branch August 10, 2024 18:32
@nekevss nekevss added the C-api Changes related to the public API label Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nekevss nekevss nekevss approved these changes

Assignees
No one assigned
Labels
C-api Changes related to the public API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonwilliams @nekevss