Skip to content

GCC suggest-override warnings #315

Open
@EugeneZelenko

Description

@EugeneZelenko

Complete list of warnings when Boost 1.72 is built with GCC 7.5 with -Wsuggest-override added to cxxflags. Duplicated warnings from same location are omitted:

./boost/thread/detail/nullary_function.hpp:158:11: warning: ‘R boost::detail::nullary_function::impl_type::call() [with F = boost::thread_detail::default_barrier_reseter; R = long unsigned int]’ can be marked override [-Wsuggest-override]
./boost/thread/detail/nullary_function.hpp:62:14: warning: ‘virtual void boost::detail::nullary_function::impl_type_ptr::call()’ can be marked override [-Wsuggest-override]
./boost/thread/detail/thread.hpp:118:18: warning: ‘void boost::detail::thread_data::run() [with F = boost::_bi::bind_t, boost::log::v2_mt_posix::sinks::unbounded_fifo_queue> >, boost::_bi::list1, boost::log::v2_mt_posix::sinks::unbounded_fifo_queue>*> > >]’ can be marked override [-Wsuggest-override]
./boost/thread/detail/thread.hpp:804:18: warning: ‘void boost::detail::thread_exit_function::operator()() [with F = boost::_bi::bind_t, boost::_bi::list1 > >]’ can be marked override [-Wsuggest-override]
./boost/thread/future.hpp:319:18: warning: ‘virtual void boost::detail::shared_state::do_continuation(boost::unique_lock&)’ can be marked override [-Wsuggest-override]
./boost/thread/future.hpp:3465:18: warning: ‘virtual void boost::detail::task_shared_state::do_apply()’ can be marked override [-Wsuggest-override]
./boost/thread/future.hpp:3486:18: warning: ‘virtual void boost::detail::task_shared_state::do_run()’ can be marked override [-Wsuggest-override]
./boost/thread/future.hpp:947:24: warning: ‘void boost::detail::future_async_shared_state_base::wait(boost::unique_lock&, bool) [with Rp = void]’ can be marked override [-Wsuggest-override]
libs/thread/src/future.cpp:23:29: warning: ‘virtual const char* boost::thread_detail::future_error_category::name() const’ can be marked override [-Wsuggest-override]
libs/thread/src/future.cpp:24:29: warning: ‘virtual std::__cxx11::string boost::thread_detail::future_error_category::message(int) const’ can be marked override [-Wsuggest-override]
libs/thread/src/pthread/thread.cpp:225:18: warning: ‘virtual void boost::detail::externally_launched_thread::run()’ can be marked override [-Wsuggest-override]
libs/thread/src/pthread/thread.cpp:227:18: warning: ‘virtual void boost::detail::externally_launched_thread::notify_all_at_thread_exit(boost::condition_variable*, boost::mutex*)’ can be marked override [-Wsuggest-override]

BOOST_OVERRIDE was introduced in boostorg/config@ffe4e0f.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions