Fix: prevent rare crash in GifDrawable.draw() when bitmap is null or … #5522
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this fixes
This PR prevents a rare crash in
GifDrawable.draw()
whendrawBitmap()
is called on a null or recycled bitmap.Why it matters
In large-scale production apps, this crash is observed occasionally (e.g., 100–200 times per 100k loads).
The crash happens because
GifDrawable
may try to draw a recycled or null bitmap during frame rendering.Due to how Glide’s animation pipeline works internally, this crash cannot be caught by external
Drawable
orImageView
wrappers — Glide manages theDrawable.Callback
lifecycle internally.Fix
This PR adds a simple safety check inside
GifDrawable.draw()
: