Remove an unneeded doc, fixing the doc build on stable Rust. #627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove a doc comment which is redundant because it's on a re-export of an item which already has its own doc comment. This also happens to work around a bug in at least Rust 1.69. Fixes #624.
tempfile 3.5.0 depends on rustix 0.37. Pin to tempfile 3.4.0 since it uses rustix 0.36 as this is the rustix 0.36 branch.
FreeBSD CI is currently broken with this error ``` [4/4] Extracting curl-7.88.1: .......... done curl https://sh.rustup.rs -sSf --output rustup.sh ld-elf.so.1: /usr/local/lib/libcurl.so.4: Undefined symbol "nghttp2_option_set_no_rfc9113_leading_and_trailing_ws_validation" ``` From some quick searches I found [this bug] which looks related, but I didn't see anything in the discussion which would let us work around the problem. [this bug]: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=269253
aqrln
added a commit
to prisma/prisma-engines
that referenced
this pull request
May 8, 2023
Update rustix with `cargo update -p rustix`. This should work around the ICE that happens when running `cargo doc` on CI: https://github.com/prisma/prisma-engines/actions/runs/4915235114/jobs/8777494487. The ICE is already fixed in beta and nightly but not in stable yet (rust-lang/rust#109424). Newer versions of rustix than we have don't trigger the bug because it was worked around in bytecodealliance/rustix#627.
aqrln
added a commit
to prisma/prisma-engines
that referenced
this pull request
May 8, 2023
Update rustix with `cargo update -p rustix`. This should work around the ICE that happens when running `cargo doc` on CI: https://github.com/prisma/prisma-engines/actions/runs/4915235114/jobs/8777494487. The ICE is already fixed in beta and nightly but not in stable yet (rust-lang/rust#109424). Newer versions of rustix than we have don't trigger the bug because it was worked around in bytecodealliance/rustix#627.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a doc comment which is redundant because it's on a re-export of an item which already has its own doc comment. This also happens to work around a bug in at least Rust 1.69.
Fixes #624.