Test out s390x inline assembly change in isolation #10973
Draft
+3
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracted from bytecodealliance#10960 prtest:linux-s390x
|
I'm pretty perplexed staring at this one too -- for reference here are Godbolt links for before (working) and after (apparently segfaulting). The clobber-saves come in different order wrt loading values into payload (r6/r7) but the dataflow from arguments to PC/SP (r15)/payload (r6, r7) looks completely equivalent... |
|
cc @uweigand would you be able to help dig in to what's going on here? (we can provide more background context if necessary, but the general gist is that this PR in theory is a refactoring that shouldn't do anything but it causes tests to segfault) |
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Jun 9, 2025
This was split out of bytecodealliance#10960 after some CI issues. The simplification of s390x is split to bytecodealliance#10973 to show its failure but otherwise these changes aren't expected to cause any issues (yet). Part of enabling this was in bytecodealliance#10974 where ASAN showed some issues as well. prtest:full
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #10960
prtest:linux-s390x