Skip to content

Commit 639fec9

Browse files
authored
Refactor ActivityTaskExecutor to use ActivityTask interface (#897)
* Refactor ActivityTaskExecutor to use ActivityTask interface * lint
1 parent b715950 commit 639fec9

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

src/main/java/com/uber/cadence/activity/ActivityTask.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,4 +65,6 @@ public interface ActivityTask {
6565
String getWorkflowDomain();
6666

6767
int getAttempt();
68+
69+
byte[] getInput();
6870
}

src/main/java/com/uber/cadence/internal/sync/POJOActivityTaskHandler.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
import com.uber.cadence.RespondActivityTaskCompletedRequest;
2525
import com.uber.cadence.RespondActivityTaskFailedRequest;
2626
import com.uber.cadence.activity.ActivityMethod;
27+
import com.uber.cadence.activity.ActivityTask;
2728
import com.uber.cadence.client.ActivityCancelledException;
2829
import com.uber.cadence.common.MethodRetry;
2930
import com.uber.cadence.converter.DataConverter;
@@ -201,7 +202,7 @@ public Result handle(
201202
}
202203

203204
interface ActivityTaskExecutor {
204-
ActivityTaskHandler.Result execute(ActivityTaskImpl task, Scope metricsScope);
205+
ActivityTaskHandler.Result execute(ActivityTask task, Scope metricsScope);
205206
}
206207

207208
private class POJOActivityImplementation implements ActivityTaskExecutor {
@@ -214,7 +215,7 @@ private class POJOActivityImplementation implements ActivityTaskExecutor {
214215
}
215216

216217
@Override
217-
public ActivityTaskHandler.Result execute(ActivityTaskImpl task, Scope metricsScope) {
218+
public ActivityTaskHandler.Result execute(ActivityTask task, Scope metricsScope) {
218219
ActivityExecutionContext context =
219220
new ActivityExecutionContextImpl(service, domain, task, dataConverter, heartbeatExecutor);
220221
byte[] input = task.getInput();
@@ -250,7 +251,7 @@ private class POJOLocalActivityImplementation implements ActivityTaskExecutor {
250251
}
251252

252253
@Override
253-
public ActivityTaskHandler.Result execute(ActivityTaskImpl task, Scope metricsScope) {
254+
public ActivityTaskHandler.Result execute(ActivityTask task, Scope metricsScope) {
254255
ActivityExecutionContext context =
255256
new LocalActivityExecutionContextImpl(service, domain, task);
256257
CurrentActivityExecutionContext.set(context);

0 commit comments

Comments
 (0)