Skip to content

Refactor ActivityTaskExecutor to use ActivityTask interface #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

shijiesheng
Copy link
Member

What changed?

Correctly use ActivityTask interface rather than the implementation directly in the interface.

Why?

How did you test it?

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2328

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.04%) to 61.473%

Files with Coverage Reduction New Missed Lines %
src/main/java/com/uber/cadence/internal/worker/Poller.java 1 78.13%
src/main/java/com/uber/cadence/serviceclient/WorkflowServiceTChannel.java 2 10.99%
Totals Coverage Status
Change from base Build 2311: 0.04%
Covered Lines: 11962
Relevant Lines: 19459

💛 - Coveralls

Copy link
Member

@natemort natemort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, makes sense. It's interesting that we didn't include the input in ActivityTask before but I don't see any harm in doing so.

@abhishekj720 abhishekj720 merged commit 639fec9 into cadence-workflow:master May 15, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants