Skip to content

Fix memory leak caused by incorrect context deactivation #896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 15, 2024

Conversation

shijiesheng
Copy link
Member

What changed?
"Scope" the tracing scope so it's closed and removed from thread local storage.

Why?
#895

How did you test it?
unit test + integration test

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2326

Details

  • 67 of 69 (97.1%) changed or added relevant lines in 6 files are covered.
  • 9 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.08%) to 61.521%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/uber/cadence/internal/worker/LocalActivityWorker.java 28 29 96.55%
src/main/java/com/uber/cadence/serviceclient/WorkflowServiceTChannel.java 3 4 75.0%
Files with Coverage Reduction New Missed Lines %
src/main/java/com/uber/cadence/internal/replay/ReplayDecisionTaskHandler.java 1 87.8%
src/main/java/com/uber/cadence/internal/worker/Poller.java 1 78.13%
src/main/java/com/uber/cadence/serviceclient/WorkflowServiceTChannel.java 3 11.1%
src/main/java/com/uber/cadence/internal/common/BackoffThrottler.java 4 68.42%
Totals Coverage Status
Change from base Build 2311: 0.08%
Covered Lines: 11975
Relevant Lines: 19465

💛 - Coveralls

@natemort natemort merged commit 794dc95 into cadence-workflow:master May 15, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants