Invalidate global vars containing parsed images in Explore* methods #210
Conversation
|
Thank you for catching this issue! I like the idea, but it looks like we currently invalidate the cache even if we are running the command on the same directory as before. It would be good if we can have another global variable that stores the directory that we are caching the images from. We can compare this to the dir passed into |
|
It looks like you were already doing the above in the first commit :) that would be nice to have. Please note that we use self-contained commits without follow-up fixup commits -please squash your commits into a single one. It would also be great if you could write a descriptive commit message that explains the intent of the commit better. Thanks! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #210 +/- ##
==========================================
+ Coverage 49.80% 50.12% +0.32%
==========================================
Files 21 21
Lines 2307 2322 +15
==========================================
+ Hits 1149 1164 +15
Misses 1019 1019
Partials 139 139 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Caching common criu images in global variables doesn't work in these scenarios: 1. crit.Explore...() are used in different img directories 2. between crit.Explore...() img files are updated (new dump happened) This patch fixes this problem by invalidating the caches during each Explore call. Signed-off-by: Pavel Beschetnov <[email protected]> Signed-off-by: Radostin Stoyanov <[email protected]>
Caching common criu images in global variables doesn't work in these scenarios:
With this PR I'm fixing this problem and supporting listed cases by invalidating the caches during each Explore call.