Skip to content

Fix 307 temporary redirect refactor #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 23 additions & 8 deletions src/mcp/server/fastmcp/server.py
Original file line number Diff line number Diff line change
Expand Up @@ -770,7 +770,7 @@ async def sse_endpoint(request: Request) -> Response:
def streamable_http_app(self) -> Starlette:
"""Return an instance of the StreamableHTTP server app."""
from starlette.middleware import Middleware
from starlette.routing import Mount
from starlette.routing import Mount, Router

# Create session manager on first call (lazy initialization)
if self._session_manager is None:
Expand All @@ -787,12 +787,24 @@ async def handle_streamable_http(
) -> None:
await self.session_manager.handle_request(scope, receive, send)

# Create routes
routes: list[Route | Mount] = []
async def streamable_http_endpoint(request: Request):
return await handle_streamable_http(request.scope, request.receive, request._send) # type: ignore[reportPrivateUsage]

# Normalize the main path (no trailing slash)
_main_path = self.settings.streamable_http_path.removesuffix("/")

streamable_router = Router(
routes=[
Route("/", endpoint=streamable_http_endpoint, methods=["GET", "POST"]),
],
redirect_slashes=False,
)

routes: list[Route | Mount ] = []
middleware: list[Middleware] = []
required_scopes = []

# Add auth endpoints if auth provider is configured
# Auth endpoints if auth provider is configured
if self._auth_server_provider:
assert self.settings.auth
from mcp.server.auth.routes import create_auth_routes
Expand All @@ -817,18 +829,21 @@ async def handle_streamable_http(
revocation_options=self.settings.auth.revocation_options,
)
)

routes.append(
Mount(
self.settings.streamable_http_path,
app=RequireAuthMiddleware(handle_streamable_http, required_scopes),
_main_path,
app=RequireAuthMiddleware(
streamable_router, required_scopes
),
)
)
else:
# Auth is disabled, no wrapper needed
routes.append(
Mount(
self.settings.streamable_http_path,
app=handle_streamable_http,
_main_path,
app=streamable_router,
)
)

Expand Down
14 changes: 14 additions & 0 deletions tests/server/fastmcp/test_server.py
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,20 @@ async def test_starlette_routes_with_mount_path(self):
mount_routes[0].path == "/messages"
), "Mount route path should be /messages"

mcp = FastMCP()
app = mcp.streamable_http_app()

# Find routes by type
streamable_routes = [r for r in app.routes if isinstance(r, Mount)]

# Verify routes exist
assert len(streamable_routes) == 1, "Should have two streamable routes"

# Verify path values
assert (
streamable_routes[0].path == "/mcp"
), "Streamable route path should be /mcp"

@pytest.mark.anyio
async def test_non_ascii_description(self):
"""Test that FastMCP handles non-ASCII characters in descriptions correctly"""
Expand Down