[ENH] add regeneration script for js library #4115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
jairad26
force-pushed
the
jai/js-client-regen
branch
from
8eb42a0 to
fc6c500
Compare
jairad26
commented
Mar 30, 2025
jairad26
commented
Mar 30, 2025
jairad26
force-pushed
the
jai/js-client-regen
branch
6 times, most recently
from
14ca0bb to
e899a42
Compare
1 task
codetheweb
reviewed
Mar 31, 2025
jairad26
force-pushed
the
jai/js-client-regen
branch
11 times, most recently
from
48d0344 to
e5513bc
Compare
philipithomas
approved these changes
Apr 1, 2025
codetheweb
approved these changes
Apr 1, 2025
jairad26
force-pushed
the
jai/js-client-regen
branch
from
fc4ab73 to
db274a6
Compare
jairad26
changed the base branch from
03-25-server-coll-config-response
to
graphite-base/4115
jairad26
force-pushed
the
jai/js-client-regen
branch
from
ce1b2c1 to
3140593
Compare
jairad26
force-pushed
the
graphite-base/4115
branch
from
b29f535 to
7a3f562
Compare
jairad26
force-pushed
the
jai/js-client-regen
branch
6 times, most recently
from
794ec4e to
d0fc2ff
Compare
jairad26
force-pushed
the
jai/js-client-regen
branch
from
d0fc2ff to
8af4235
Compare
Compaction assumes that enumeration position t_i means t_i was the last record seen and therefore next reader should read from t_i + 1. Log service was built and tested for t_i meaning t_i was the first record to return. Note: I changed the go code, but only by moving a +1 out a layer. The inner version was inconsistent with convention, so I updated it.
philipithomas
requested changes
Apr 15, 2025
|
Do we need |
philipithomas
approved these changes
Apr 15, 2025
…chroma into jai/js-client-regen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR updates the regeneration script for the JS library to fix failing generation on the new openapi spec. It also overhauls the used functions, renaming the V2 references back to the normal references as per the openapi spec.
Test plan
How are these changes tested?
pytestfor python,yarn testfor js,cargo testfor rustDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?