-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[ENH] Reenable wal3 #4261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[ENH] Reenable wal3 #4261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas |
de1b2d2
to
91153ac
Compare
This will make the 50052 port and go service go untested, at the benefit of testing the new service.
7ffecfa
to
84630a9
Compare
sanketkedia
pushed a commit
that referenced
this pull request
Apr 15, 2025
This will make the 50052 port and go service go untested, at the benefit of testing the new service. To make tests pass, I had to up the fetch_logs_batch_size in testing. This will not affect staging or prod. Also bundled: Tracing changes.
sanketkedia
pushed a commit
that referenced
this pull request
Apr 17, 2025
This will make the 50052 port and go service go untested, at the benefit of testing the new service. To make tests pass, I had to up the fetch_logs_batch_size in testing. This will not affect staging or prod. Also bundled: Tracing changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make the 50052 port and go service go untested, at the benefit of testing the new service.
To make tests pass, I had to up the fetch_logs_batch_size in testing. This will not affect staging or prod.
Also bundled: Tracing changes.