Skip to content

[ENH] Reenable wal3 #4261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 11, 2025
Merged

[ENH] Reenable wal3 #4261

merged 7 commits into from
Apr 11, 2025

Conversation

rescrv
Copy link
Contributor

@rescrv rescrv commented Apr 10, 2025

This will make the 50052 port and go service go untested, at the benefit of testing the new service.

To make tests pass, I had to up the fetch_logs_batch_size in testing. This will not affect staging or prod.

Also bundled: Tracing changes.

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

@rescrv rescrv changed the title rescrv/reenable wal3 [ENH] Reenable wal3 Apr 10, 2025
@rescrv rescrv changed the base branch from main to rescrv/scout-logs April 10, 2025 19:39
Base automatically changed from rescrv/scout-logs to main April 10, 2025 20:07
@rescrv rescrv force-pushed the rescrv/reenable-wal3 branch from de1b2d2 to 91153ac Compare April 10, 2025 20:15
@rescrv rescrv requested a review from sanketkedia April 10, 2025 20:15
@rescrv rescrv force-pushed the rescrv/reenable-wal3 branch from 7ffecfa to 84630a9 Compare April 11, 2025 16:55
@rescrv rescrv merged commit 5c71b6d into main Apr 11, 2025
68 checks passed
@rescrv rescrv deleted the rescrv/reenable-wal3 branch April 11, 2025 17:55
sanketkedia pushed a commit that referenced this pull request Apr 15, 2025
This will make the 50052 port and go service go untested, at the benefit
of testing the new service.

To make tests pass, I had to up the fetch_logs_batch_size in testing.
This will not affect staging or prod.

Also bundled:  Tracing changes.
sanketkedia pushed a commit that referenced this pull request Apr 17, 2025
This will make the 50052 port and go service go untested, at the benefit
of testing the new service.

To make tests pass, I had to up the fetch_logs_batch_size in testing.
This will not affect staging or prod.

Also bundled:  Tracing changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant