Skip to content

[ENH] Fixed Dockerfile for the current genertion of chroma project #4270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 24, 2025

Conversation

j0hnthebuilder
Copy link
Contributor

ENH: Enhancement, new functionality
BUG: The Current broken Dockerfile has been fixed
DOC: no addition to the documentation yet
TST: no tests
BLD: This is an update to the current Dockerfile

All credit goes to @tazarov for providing this new docker file, I just tested it for the latest version and it works perfectley

updated the Dockerfile that builds the rust bindings for new chroma version
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@jairad26
Copy link
Contributor

thank you for the PR! could you update the title and push an empty commit please

@j0hnthebuilder
Copy link
Contributor Author

of course, just to make sure I'm doing it the expected way, is the following a good title:
[ENH] Fixed Dockerfile for the current genertion of chroma project

@j0hnthebuilder j0hnthebuilder changed the title Fixed Dockerfile for the current genertion of chroma project [ENH] Fixed Dockerfile for the current genertion of chroma project Apr 11, 2025
@j0hnthebuilder j0hnthebuilder changed the title [ENH] Fixed Dockerfile for the current genertion of chroma project Fixed Dockerfile for the current genertion of chroma project Apr 11, 2025
@j0hnthebuilder j0hnthebuilder changed the title Fixed Dockerfile for the current genertion of chroma project [ENH] Fixed Dockerfile for the current genertion of chroma project Apr 11, 2025
@j0hnthebuilder
Copy link
Contributor Author

done :)

@jairad26
Copy link
Contributor

could you rebase off main and push?

@j0hnthebuilder
Copy link
Contributor Author

I just did something, is it correct? :)

@j0hnthebuilder
Copy link
Contributor Author

Hi @jairad26 :D
Anything I could help out with this? 🙏

@jairad26 jairad26 enabled auto-merge (squash) April 24, 2025 23:14
@jairad26 jairad26 merged commit 681d9e7 into chroma-core:main Apr 24, 2025
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants