Skip to content

[CHORE] Demote "Block: <UUID> written to storage (<>B)" to debug #4308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2025

Conversation

rescrv
Copy link
Contributor

@rescrv rescrv commented Apr 17, 2025

This only affects a single log line that's quite spammy.

This only affects a single log line that's quite spammy.
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@rescrv rescrv requested a review from Copilot April 17, 2025 20:22
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

The purpose of this PR is to demote a verbose log message from info level to debug to reduce spam in the logs.

  • Demote log level from info to debug for the storage write log message.

@rescrv rescrv enabled auto-merge (squash) April 17, 2025 20:24
@HammadB HammadB disabled auto-merge April 21, 2025 14:49
@HammadB HammadB merged commit b4c6fc9 into main Apr 21, 2025
67 of 69 checks passed
@rescrv rescrv deleted the rescrv/log-line-demote branch April 21, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants