Skip to content

[BUG] Handle uninitialized spann segment reader #4348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sanketkedia
Copy link
Contributor

@sanketkedia sanketkedia commented Apr 22, 2025

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Handles the case when no data in the segments but only on the log for spann
    • Increase the max_block_size for local tilt to 8MB (consistent with staging/prod) since posting lists can be bigger than the size that's currently the max in local
  • New functionality
    • ...

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link
Contributor Author

sanketkedia commented Apr 22, 2025

@sanketkedia sanketkedia marked this pull request as ready for review April 22, 2025 18:45
@sanketkedia sanketkedia force-pushed the 04-22-_bug_fix_race_between_hnsw_load_and_hnsw_purge branch from c916ed8 to cbd9a5d Compare April 22, 2025 22:36
@sanketkedia sanketkedia force-pushed the 04-22-_bug_handle_uninitialized_spann_segment_reader branch from f871782 to dd45b86 Compare April 22, 2025 22:36
@sanketkedia sanketkedia force-pushed the 04-22-_bug_fix_race_between_hnsw_load_and_hnsw_purge branch from cbd9a5d to dacf3ca Compare April 23, 2025 18:49
@sanketkedia sanketkedia force-pushed the 04-22-_bug_handle_uninitialized_spann_segment_reader branch 3 times, most recently from f7f05ff to 638effd Compare April 24, 2025 18:59
@sanketkedia sanketkedia changed the base branch from 04-22-_bug_fix_race_between_hnsw_load_and_hnsw_purge to graphite-base/4348 April 24, 2025 21:39
@sanketkedia sanketkedia force-pushed the 04-22-_bug_handle_uninitialized_spann_segment_reader branch from 638effd to 2cc86a6 Compare April 24, 2025 21:39
@graphite-app graphite-app bot changed the base branch from graphite-base/4348 to main April 24, 2025 21:40
@sanketkedia sanketkedia force-pushed the 04-22-_bug_handle_uninitialized_spann_segment_reader branch from 2cc86a6 to 12d21e6 Compare April 24, 2025 21:40
@sanketkedia sanketkedia force-pushed the 04-22-_bug_handle_uninitialized_spann_segment_reader branch from 12d21e6 to ae596ac Compare April 24, 2025 23:11
@sanketkedia sanketkedia merged commit 30affb7 into main Apr 24, 2025
67 checks passed
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 24, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 24, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 24, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 24, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants