Skip to content

[BUG] Fix log fork bugs #4356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 23, 2025
Merged

[BUG] Fix log fork bugs #4356

merged 2 commits into from
Apr 23, 2025

Conversation

Sicheng-Pan
Copy link
Contributor

@Sicheng-Pan Sicheng-Pan commented Apr 23, 2025 •
edited
Loading

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Fixes a typo in log fork impl that led to wrong enumeration offset for the new collection
    • Replaces updates with insert when populating the offsets for the new collection
  • New functionality
    • ...

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@Sicheng-Pan Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Sicheng-Pan Sicheng-Pan marked this pull request as ready for review April 23, 2025 00:15
@Sicheng-Pan Sicheng-Pan force-pushed the sicheng/04-22-_bug_fix_log_fork_typo branch from b929ee5 to c5a48c5 Compare April 23, 2025 00:19
HammadB
HammadB reviewed Apr 23, 2025
View reviewed changes
Copy link
Collaborator

@HammadB HammadB left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fact that this is possible makes me think our testing is not sufficient.

@Sicheng-Pan Sicheng-Pan changed the title [BUG] Fix log fork typo [BUG] Fix log fork bugs Apr 23, 2025
@Sicheng-Pan Sicheng-Pan enabled auto-merge (squash) April 23, 2025 00:26
@Sicheng-Pan Sicheng-Pan disabled auto-merge April 23, 2025 00:26
@Sicheng-Pan
Copy link
Contributor Author

The fact that this is possible makes me think our testing is not sufficient.

Will add tests later. The code is fairly flaky right now

@Sicheng-Pan Sicheng-Pan merged commit 07adae0 into main Apr 23, 2025
66 of 67 checks passed
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 24, 2025
@warpbuild-benchmark-bot
[BUG] Fix log fork bugs (chroma-core#4356)
61c9458
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 24, 2025
@warpbuild-benchmark-bot
[BUG] Fix log fork bugs (chroma-core#4356)
e50a4cc
@Sicheng-Pan Sicheng-Pan deleted the sicheng/04-22-_bug_fix_log_fork_typo branch May 28, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HammadB HammadB HammadB left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sicheng-Pan @HammadB