Skip to content

[CHORE]: Discord - link to channel #4363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hesreallyhim
Copy link
Contributor

Description of changes

This is just closing the loop on #4130 , which seems to have gotten out of sync with my local branch, so the revision requests I was responding to weren't getting pushed up, so I'll just close that one. Also, I noticed that in the meantime @jeffchuber already merged a PR #4286 with my changes, the only difference being that this adds a link to the channel. 🤷

So this is a really trivial PR, just making it so that I can close out the other one and maybe you like this minuscule enhancement.
@jairad26

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@jeffchuber jeffchuber self-requested a review April 23, 2025 20:28
@jeffchuber jeffchuber merged commit 68f8f3a into chroma-core:main Apr 23, 2025
1 check passed
@jeffchuber
Copy link
Contributor

thank you! will get this deployed. good change

warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 23, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants